From: Jasper St. Pierre <jstpierre@mecheye.net>
Date: Fri, 26 Apr 2013 05:34:50 +0000 (-0400)
Subject: network: Fix some splice mishaps
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~4266
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=20619ad3c129c1d869cd1dd43ab2f743eb1f73ab;p=gnome-shell.git

network: Fix some splice mishaps

Calling splice() without a second argument removes all of the elements
after the provided index, not just one.

https://bugzilla.gnome.org/show_bug.cgi?id=698918
---

diff --git a/js/ui/status/network.js b/js/ui/status/network.js
index cb5245817..2cef443b9 100644
--- a/js/ui/status/network.js
+++ b/js/ui/status/network.js
@@ -1266,7 +1266,7 @@ const NMDeviceWireless = new Lang.Class({
             for (let k = 0; k < connections.length; k++) {
                 if (connections[k].get_uuid() == connection.get_uuid()) {
                     // remove the connection from the access point group
-                    connections.splice(k);
+                    connections.splice(k, 1);
                     forceupdate = forceupdate || connections.length == 0;
 
                     if (forceupdate)
@@ -2120,7 +2120,7 @@ const NMApplet = new Lang.Class({
     _connectionRemoved: function(connection) {
         let pos = this._connections.indexOf(connection);
         if (pos != -1)
-            this._connections.splice(connection);
+            this._connections.splice(connection, 1);
 
         let section = connection._section;